gustavonihei commented on a change in pull request #5069:
URL: https://github.com/apache/incubator-nuttx/pull/5069#discussion_r774780549
##########
File path: tools/Makefile.unix
##########
@@ -524,9 +581,16 @@ config: apps_preconfig
$(Q) APPSDIR=${CONFIG_APPS_DIR} EXTERNALDIR=$(EXTERNALDIR) kconfig-conf
Kconfig
oldconfig: apps_preconfig
+ echo $@
$(Q) APPSDIR=${CONFIG_APPS_DIR} EXTERNALDIR=$(EXTERNALDIR) kconfig-conf
--oldconfig Kconfig
-olddefconfig: apps_preconfig
+# olddefconfig first needs to clear the context, to ensure the configuration
is up to date,
+# and no old artifacts (i.e. symlinks) still exist. By settings .NOTPARALLEL,
we can enforce
+# order and ensure clean_context is executed first
Review comment:
```suggestion
# olddefconfig first needs to clear the context to ensure the configuration
is up to date
# and no old artifacts (i.e. symlinks) still exist. By setting .NOTPARALLEL
we can enforce
# order and ensure clean_context is executed first.
```
nit: Commas here seem unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
