pkarashchenko commented on a change in pull request #5028:
URL: https://github.com/apache/incubator-nuttx/pull/5028#discussion_r771846846
##########
File path: fs/vfs/fs_eventfd.c
##########
@@ -66,10 +66,10 @@ struct eventfd_priv_s
sem_t exclsem; /* Enforces device exclusive access */
eventfd_waiter_sem_t *rdsems; /* List of blocking readers */
eventfd_waiter_sem_t *wrsems; /* List of blocking writers */
- eventfd_t counter; /* eventfd counter */
- size_t minor; /* eventfd minor number */
- uint8_t crefs; /* References counts on eventfd (max: 255) */
- uint8_t mode_semaphore; /* eventfd mode (semaphore or counter) */
+ eventfd_t counter; /* eventfd counter */
+ unsigned int minor; /* eventfd minor number */
+ uint8_t crefs; /* References counts on eventfd (max: 255) */
+ uint8_t mode_semaphore; /* eventfd mode (semaphore or counter) */
Review comment:
Should we use `bool` here instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
