pkarashchenko commented on a change in pull request #4908: URL: https://github.com/apache/incubator-nuttx/pull/4908#discussion_r757884471
########## File path: boards/arm/stm32h7/nucleo-h743zi/configs/mcuboot-app/defconfig ########## @@ -0,0 +1,141 @@ +# +# This file is autogenerated: PLEASE DO NOT EDIT IT. +# +# You can use "make menuconfig" to make any modifications to the installed .config file. +# You can then do "make savedefconfig" to generate a new defconfig file that includes your +# modifications. +# +# CONFIG_SPI_EXCHANGE is not set +# CONFIG_STM32H7_SYSCFG is not set +CONFIG_ARCH="arm" +CONFIG_ARCH_BOARD="nucleo-h743zi" +CONFIG_ARCH_BOARD_NUCLEO_H743ZI=y +CONFIG_ARCH_CHIP="stm32h7" +CONFIG_ARCH_CHIP_STM32H743ZI=y +CONFIG_ARCH_CHIP_STM32H7=y +CONFIG_ARCH_STACKDUMP=y +CONFIG_ARMV7M_BASEPRI_WAR=y +CONFIG_ARMV7M_DCACHE=y +CONFIG_ARMV7M_DTCM=y +CONFIG_ARMV7M_ICACHE=y +CONFIG_ARMV7M_MEMCPY=y +CONFIG_ARMV7M_STACKCHECK=y +CONFIG_ARMV7M_USEBASEPRI=y +CONFIG_ARM_MPU_EARLY_RESET=y +CONFIG_BOARDCTL_RESET=y +CONFIG_BOARD_CUSTOM_LEDS=y +CONFIG_BOARD_LOOPSPERMSEC=43103 +CONFIG_BOOT_MCUBOOT=y +CONFIG_BUILTIN=y +CONFIG_CLOCK_MONOTONIC=y +CONFIG_DEBUG_FEATURES=y +CONFIG_DEBUG_IRQ=y +CONFIG_DEBUG_NET=y +CONFIG_DEBUG_SYMBOLS=y +CONFIG_DRVR_READAHEAD=y +CONFIG_DRVR_WRITEBUFFER=y +CONFIG_ETH0_PHY_LAN8742A=y +CONFIG_EXAMPLES_LEDS=y +CONFIG_EXAMPLES_LEDS_LEDSET=0x03 +CONFIG_EXAMPLES_TCPECHO=y +CONFIG_EXPERIMENTAL=y +CONFIG_FAT_LCNAMES=y +CONFIG_FAT_LFN=y +CONFIG_FS_FAT=y +CONFIG_FS_PROCFS=y +CONFIG_FS_ROMFS=y +CONFIG_FTL_WRITEBUFFER=y +CONFIG_HAVE_CXX=y +CONFIG_HAVE_CXXINITIALIZE=y +CONFIG_I2C=y +CONFIG_IOB_NBUFFERS=24 +CONFIG_IOB_THROTTLE=0 +CONFIG_LIBC_LZF=y +CONFIG_LIBM=y +CONFIG_MCUBOOT_SLOT_CONFIRM_EXAMPLE=y +CONFIG_MCUBOOT_VERSION="ecd34c116873bf187a3d7431151249ec856738d0" +CONFIG_MMCSD=y +CONFIG_MM_CIRCBUF=y +CONFIG_MM_REGIONS=4 +CONFIG_MTD=y +CONFIG_MTD_PARTITION=y +CONFIG_MTD_PROGMEM=y Review comment: I see that you defaulted `APP_FORMAT_MCUBOOT` to `y`, then should other configs be regenerated to add `# CONFIG_APP_FORMAT_MCUBOOT is not set`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org