Donny9 commented on a change in pull request #4833:
URL: https://github.com/apache/incubator-nuttx/pull/4833#discussion_r749864567
##########
File path: drivers/motor/foc/foc_dev.c
##########
@@ -147,19 +142,13 @@ static int foc_open(FAR struct file *filep)
if (tmp == 1)
{
- /* Yes.. perform one time driver setup */
-
- flags = enter_critical_section();
-
Review comment:
yes, I also think the critical section should be done by lower half of
the driver, more detailed control.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
