yamt commented on pull request #4659:
URL: https://github.com/apache/incubator-nuttx/pull/4659#issuecomment-964816647


   > > > > i still think it's better to do it with cwnd-like structure. let me 
think a bit.
   > > > 
   > > > 
   > > > By "cwnd" do you mean congestion window control algorithm or something 
else?
   > > 
   > > 
   > > yes, congestion window. clamping the window to one segment for 
retransmit is what this patch does, right?
   > 
   > You are saying about RFC 5681 (slow start of sending data etc.). My patch 
is not related to the congestion window control. My patch instead just fixes a 
basic requirement (RFC 6298 (5.4)) how a TCP segment should be retransmitted 
e.g. in case of ACK timeout. If it is detected that a segment is lost, only 
that particular segment should be retransmitted. However, currently NuttX 
TCP/IP stack (at least "unbuffered send" mode) retransmits all segments between 
NACK and SEQ provoking network traffic collapse. The congestion window control 
is a separate advanced algorithm that I think could be implemented in NuttX 
TCP/IP stack as an option.
   
   separate? maybe. but they can be implemented with the common machinary.
   
   i will think a bit more, but because of holidays etc, i suspect it will take 
at least a few weeks.
   i'm going to approve this for now.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to