xiaoxiang781216 commented on a change in pull request #4743:
URL: https://github.com/apache/incubator-nuttx/pull/4743#discussion_r740700515
##########
File path: arch/arm/src/arm/Toolchain.defs
##########
@@ -67,6 +67,10 @@ else
MAXOPTIMIZATION ?= -Os
endif
+ifeq ($(CONFIG_MM_KASAN),y)
+ MAXOPTIMIZATION += -fsanitize=kernel-address
Review comment:
The new option require we modify all boards/**/scripts/Make.defs, or we
let user add -fsanitize=kernel-address manually.
##########
File path: arch/arm/src/arm/Toolchain.defs
##########
@@ -67,6 +67,10 @@ else
MAXOPTIMIZATION ?= -Os
endif
+ifeq ($(CONFIG_MM_KASAN),y)
+ MAXOPTIMIZATION += -fsanitize=kernel-address
Review comment:
Ok, I revert all change under arch/, user has to add
-fsanitize=kernel-address.
##########
File path: arch/arm/src/arm/Toolchain.defs
##########
@@ -67,6 +67,10 @@ else
MAXOPTIMIZATION ?= -Os
endif
+ifeq ($(CONFIG_MM_KASAN),y)
+ MAXOPTIMIZATION += -fsanitize=kernel-address
Review comment:
Ok, I revert all change under arch/, user has to add
-fsanitize=kernel-address. Please review again.
##########
File path: tools/ci/testlist/sim-01.dat
##########
@@ -6,16 +6,19 @@
-Darwin,sim:cxxtest
-Darwin,sim:libcxxtest
-# Do not build Linux configs
--Darwin,sim:linuxi2c
--Darwin,sim:linuxspi
+# clang doesn't -fsanitize=kernel-address
+-Darwin,sim:kasan
Review comment:
At least, clang on our macOS CI can't recognize
-fsanitize=kernel-address. Here is the link before I add kasan to the black
list(https://github.com/apache/incubator-nuttx/runs/4055120804?check_suite_focus=true):
```
clangclang: error: error: clangunsupported option
'-fsanitize=kernel-address' for target 'x86_64-apple-darwin19.6.0': : error:
unsupported option '-fsanitize=kernel-address' for target
'x86_64-apple-darwin19.6.0'
unsupported option '-fsanitize=kernel-address' for target
'x86_64-apple-darwin19.6.0'
```
##########
File path: tools/ci/testlist/sim-01.dat
##########
@@ -6,16 +6,19 @@
-Darwin,sim:cxxtest
-Darwin,sim:libcxxtest
-# Do not build Linux configs
--Darwin,sim:linuxi2c
--Darwin,sim:linuxspi
+# clang doesn't -fsanitize=kernel-address
+-Darwin,sim:kasan
Review comment:
At least, clang on our macOS CI can't recognize
-fsanitize=kernel-address. Here is the error report before I add kasan to the
black
list(https://github.com/apache/incubator-nuttx/runs/4055120804?check_suite_focus=true):
```
clangclang: error: error: clangunsupported option
'-fsanitize=kernel-address' for target 'x86_64-apple-darwin19.6.0': : error:
unsupported option '-fsanitize=kernel-address' for target
'x86_64-apple-darwin19.6.0'
unsupported option '-fsanitize=kernel-address' for target
'x86_64-apple-darwin19.6.0'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
