gustavonihei commented on a change in pull request #4725:
URL: https://github.com/apache/incubator-nuttx/pull/4725#discussion_r735651375
##########
File path: libs/libc/netdb/Kconfig
##########
@@ -83,7 +83,7 @@ config NETDB_DNSCLIENT_ENTRIES
config NETDB_DNSCLIENT_NAMESIZE
int "Max size of a cached hostname"
- default 32
+ default PATH_MAX
Review comment:
This imposes a flash footprint increase of 1792 bytes:
- 224 bytes overhead for each `struct dns_cache_s`
- `NETDB_DNSCLIENT_ENTRIES` default is 8
I believe for avoiding any breakage, maybe this PR should also set
`CONFIG_NETDB_DNSCLIENT_NAMESIZE=32` for all the defconfigs that currently
enable `CONFIG_NETDB_DNSCLIENT=y` and rely on the current default value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
