patacongo commented on a change in pull request #4693: URL: https://github.com/apache/incubator-nuttx/pull/4693#discussion_r731484565
########## File path: include/sys/types.h ########## @@ -230,8 +230,10 @@ typedef uint16_t sa_family_t; #ifdef CONFIG_SYSTEM_TIME64 typedef uint64_t clock_t; +typedef int64_t time_t; #else typedef uint32_t clock_t; +typedef int32_t time_t; #endif Review comment: POISIX *requires* that time_t be defined in time.h: https://pubs.opengroup.org/onlinepubs/7908799/xsh/time.h.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org