jarivanewijk commented on pull request #4635: URL: https://github.com/apache/incubator-nuttx/pull/4635#issuecomment-945845156
I rebased my PR again after renaming some of the functions in #4642. Took a bit longer to get back to this than anticipated. ;) I also added a configuration option CONFIG_USERLED_LOWER_READSTATE for the changes in this PR. I figured some users may want to keep the previous functionality or don't care about the proposed feature to check the LED pin state. Otherwise this would also require ALL boards with LEDs to be updated with a function definition to read the state of the appropriate pins. This may not even be easily possible under all architectures, because the LED pins are usually configured as a GPIO output, but it depends on the architecture how and if the output pinstate can be read. This should be ready for review now. Impact should be minimal, as the old functionality is preserved by default. I have tested the new functionality on a custom board with S32K144 MCU. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
