xiaoxiang781216 commented on a change in pull request #4673:
URL: https://github.com/apache/incubator-nuttx/pull/4673#discussion_r730634818
##########
File path: tools/configure.sh
##########
@@ -21,9 +21,10 @@ set -e
WD=`test -d ${0%/*} && cd ${0%/*}; pwd`
TOPDIR="${WD}/.."
+MAKE_CMD="make"
USAGE="
-USAGE: ${0} [-E] [-e] [-l|m|c|g|n] [L] [-a <app-dir>]
<board-name>:<config-name> [make-opts]
+USAGE: ${0} [-E] [-e] [-l|m|c|g|n|B] [L] [-a <app-dir>]
<board-name>:<config-name> [make-opts]
Review comment:
should we use 'b' like other command?
##########
File path: tools/configure.sh
##########
@@ -21,9 +21,10 @@ set -e
WD=`test -d ${0%/*} && cd ${0%/*}; pwd`
TOPDIR="${WD}/.."
+MAKE_CMD="make"
Review comment:
MAKE_CMD->MAKECMD like TOPDIR?
##########
File path: tools/configure.c
##########
@@ -166,7 +167,7 @@ static const char *g_optfiles[] =
static void show_usage(const char *progname, int exitcode)
{
- fprintf(stderr, "\nUSAGE: %s [-d] [-E] [-e] [-b|f] [-L] [-l|m|c|g|n] "
Review comment:
ditto
##########
File path: tools/sethost.sh
##########
@@ -22,14 +22,15 @@ set -e
progname=$0
host=
wenv=
+MAKE_CMD="make"
Review comment:
same comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
