a-lunev commented on a change in pull request #4656:
URL: https://github.com/apache/incubator-nuttx/pull/4656#discussion_r726186952
##########
File path: net/tcp/tcp_appsend.c
##########
@@ -212,10 +212,8 @@ void tcp_appsend(FAR struct net_driver_s *dev, FAR struct
tcp_conn_s *conn,
{
conn->tcpstateflags = TCP_FIN_WAIT_1;
conn->tx_unacked = 1;
- conn->nrtx = 0;
-#ifdef CONFIG_NET_TCP_WRITE_BUFFERS
conn->sndseq_max = tcp_getsequence(conn->sndseq) + 1;
-#endif
+ conn->nrtx = 0;
Review comment:
Do you mean the order of the lines?
I have moved setting conn->sndseq_max variable close to setting
conn->tx_unacked variable line by line. These two variables should be modified
as a pair (it's wrong if only one of the two variables is modified and the
other is not, like it was before my patch (setting conn->sndseq_max variable
was isolated by a conditional compilation)). Functionally the order of these
lines do not affect anything. I have placed these lines near to each other just
because I consider this more logical.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
