[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #4017: rpmsg_socket: fix rpmsg_socket_device_destroy() multi-access

[GitBox]

davids5 commented on a change in pull request #4017:
URL: https://github.com/apache/incubator-nuttx/pull/4017#discussion_r662980685



##########
File path: net/rpmsg/rpmsg_sockif.c
##########
@@ -386,7 +386,14 @@ static int rpmsg_socket_ept_cb(FAR struct rpmsg_endpoint 
*ept,
 static inline void rpmsg_socket_destroy_ept(
                     FAR struct rpmsg_socket_conn_s *conn)
 {
-  if (conn && conn->ept.rdev)
+  if (!conn)

Review comment:
       Good point. We should update the CS.
   
   It is a readability issue
   
   ```
   find . -type f | xargs grep -E '\(\!' | wc -l
   4875
   find . -type f | xargs grep -E '\(.* .= NULL' | wc -l
   6786
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org