xiaoxiang781216 commented on a change in pull request #791:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/791#discussion_r662714651
##########
File path: system/popen/popen.c
##########
@@ -253,12 +253,8 @@ FILE *popen(FAR const char *command, FAR const char *mode)
errcode = posix_spawn(&container->shell, argv[0], &file_actions,
&attr, argv, (FAR char * const *)NULL);
#else
- container->shell = task_spawn("popen", nsh_system, &file_actions,
- &attr, argv + 1, (FAR char * const *)NULL);
- if (container->shell < 0)
- {
- errcode = -container->shell;
- }
+ errcode = task_spawn(&container->shell, "popen", nsh_system, &file_actions,
+ &attr, argv, (FAR char * const *)NULL);
Review comment:
Please see #763 and apache/incubator-nuttx#3916.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
