[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #3714: Don't include debug.h from public header file

Mon, 31 May 2021 02:22:45 -0700 


masayuki2009 commented on a change in pull request #3714:
URL: https://github.com/apache/incubator-nuttx/pull/3714#discussion_r642347338



##########
File path: fs/littlefs/Make.defs
##########
@@ -31,11 +31,10 @@ CSRCS += lfs.c lfs_util.c
 DEPPATH += --dep-path littlefs/littlefs
 VPATH += :littlefs/littlefs
 
-CFLAGS += -DLFS_TRACE=finfo
-CFLAGS += -DLFS_DEBUG=finfo
-CFLAGS += -DLFS_WARN=fwarn
-CFLAGS += -DLFS_ERROR=ferr
-CFLAGS += -DLFS_ASSERT=DEBUGASSERT
+CFLAGS += -DLFS_NO_ASSERT
+CFLAGS += -DLFS_NO_DEBUG
+CFLAGS += -DLFS_NO_ERROR
+CFLAGS += -DLFS_NO_WARN

Review comment:
       @xiaoxiang781216 
   
   I think we should create a separate PR for these changes.
   What do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to