patacongo commented on a change in pull request #3626:
URL: https://github.com/apache/incubator-nuttx/pull/3626#discussion_r638228077



##########
File path: arch/arm/src/armv6-m/svcall.h
##########
@@ -124,6 +116,17 @@
 #define SYS_signal_handler_return (7)
 
 #endif /* CONFIG_BUILD_PROTECTED */
+
+/* SYS call 5:
+ *
+ * void up_pthread_start(pthread_startroutine_t startup,
+ *                       pthread_startroutine_t entrypt, pthread_addr_t arg)
+ *        noreturn_function
+ */
+
+#define SYS_pthread_start         (5)

Review comment:
       > where define SYS_pthread_exit?
   
   It is a normal system call. SYS_pthread_start is not. The start function is 
an internal chip-specific OS interface, SYS_nx_pthread_exit, is part of the 
common, normal user interface and you will find it in nuttx/syscall.  The 
actual user interface pthread_exit() is a callable function in 
libs/libc/pthread and not a system call().   The whole point of the change was 
to get pthread_exit() to run in user space.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to