patacongo commented on pull request #3517: URL: https://github.com/apache/incubator-nuttx/pull/3517#issuecomment-817863910
> As I reply before, there are five changes in this PR: > > 1. Rename g_intstackbase to g_intstacktop > > 2. Allocate the space from the lowest stack(up_stack_frame) > > 3. The stack dump/check need adjust because adj_stack_ptr point to the low end of stack > > 4. TLS data need to explicitly be allocated by up_stack_frame to ensure it's address always equals stack_alloc_ptr > > 5. vfork also need adjust since the implementation of vfork couple with how the stack memory allocate Too many!!!!!!!!!!!!! And most are completely unrelated and do not belong in the same PR. Please break up into 5 PRs. This is impossible to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
