yamt commented on issue #3157:
URL: 
https://github.com/apache/incubator-nuttx/issues/3157#issuecomment-813768748


   > I think we should:
   > 
   >     1. make syslog append newline if not present in message
   > 
   >     2. replace other newlines with a printable character
   > 
   >     3. Remove all use of "\n" inside syslog calls
   > 
   > 
   > This way we can avoid misuse of syslog()
   
   i agree it makes sense to make syslog to append a newline when forwarding 
the message to the console.
   i'm not sure about the "if not present in message" part though. it's simpler 
to do it unconditionally.
   
   we need manual investigation anyway because some code seems to assume the 
current behavior.
   eg. 
https://github.com/apache/incubator-nuttx/blob/83513e26cf92492484a369d768154a519256d33e/video/videomode/videomode_dump.c#L96-L108
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to