xiaoxiang781216 commented on pull request #3050: URL: https://github.com/apache/incubator-nuttx/pull/3050#issuecomment-803500087
> There is something that I do not really understand, regarding removing syslog channels. > > In case of `syslog_channel_remove`, or even previously when `syslog_channel` was overwritting the existing channel. > How do the resources of the old channel were deallocated? > Yes, your concern is right. syslog_channel is designed to switch the default channel to the new one during the initialization, not for switch in the runtime dynamically. So the deallocation isn't a big issue. > For example, when `syslog_file_channel` is used, and then this channel is removed, how the underlying file will be closed? > > _Maybe there is more to be done in this PR regarding this aspect?_ Yes, we need to extedn syslog_channel_s(e.g. unlink or unregister) to notify the channel. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
