Ouss4 commented on a change in pull request #3082: URL: https://github.com/apache/incubator-nuttx/pull/3082#discussion_r596107568
########## File path: tools/version.sh ########## @@ -81,6 +82,14 @@ if [ -z ${VERSION} ] ; then fi +if [ -z ${EXTRA} ] ; then + EXTRA=`git -C ${WD} tag --sort=v:refname | grep -E "nuttx-[0-9]+\.[0-9]+\.[0-9]+" | tail -1 | cut -d'-' -f3` Review comment: Yes, this is better than duplicating the same `git` command. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org