gustavonihei commented on a change in pull request #3029: URL: https://github.com/apache/incubator-nuttx/pull/3029#discussion_r592365833
########## File path: arch/risc-v/src/esp32c3/esp32c3_serial.c ########## @@ -656,9 +661,208 @@ static int esp32c3_receive(struct uart_dev_s *dev, unsigned int *status) return (int)rx_fifo; } +/**************************************************************************** + * Name: esp32c3_ioctl + * + * Description: + * All ioctl calls will be routed through this method. + * Here it's employed to implement the TERMIOS ioctls and TIOCSERGSTRUCT. + * + * Parameters: + * filep Pointer to a file structure instance. + * cmd The ioctl command. + * arg The argument of the ioctl cmd. Review comment: ```suggestion * arg The argument of the ioctl cmd. ``` nit: alignment of the parameters description ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org