xiaoxiang781216 commented on a change in pull request #2950:
URL: https://github.com/apache/incubator-nuttx/pull/2950#discussion_r585651761
##########
File path: audio/pcm_decode.c
##########
@@ -326,7 +328,7 @@ static uint16_t pcm_leuint32(uint32_t value)
* Return true if this is a valid WAV file header
*
****************************************************************************/
-
+#ifndef CONFIG_AUDIO_FORMAT_RAW
static inline bool pcm_validwav(FAR const struct wav_header_s *wav)
Review comment:
add length argument to pcm_validwav and check it here
##########
File path: audio/pcm_decode.c
##########
@@ -151,8 +151,10 @@ static uint16_t pcm_leuint32(uint32_t value);
# define pcm_leuint32(v) (v)
#endif
+#ifndef CONFIG_AUDIO_FORMAT_RAW
static inline bool pcm_validwav(FAR const struct wav_header_s *wav);
Review comment:
add length argument
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
