hartmannathan commented on pull request #2930: URL: https://github.com/apache/incubator-nuttx/pull/2930#issuecomment-786722842
(My earlier comment was incorrect. I was thinking of a different change.) Currently if no version information is available, the script returns an error code (1) and exits. This patch will change that to (silently, well almost) succeed and use the dummy value. I wonder if anyone is relying on the existing behavior of exit code, e.g., in a larger automated build system etc. Suggestion: Would it be better to introduce a new command line option that means "If version information cannot be found, use default (dummy) value"? If the new command line option is used, we get the behavior of this PR, "use dummy value". If not, we get the old behavior, "if version cannot be determined, exit with error code" ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
