gustavonihei commented on a change in pull request #2899: URL: https://github.com/apache/incubator-nuttx/pull/2899#discussion_r581903906
########## File path: include/sys/poll.h ########## @@ -78,8 +78,7 @@ #define POLLFD (0x00) #define POLLFILE (0x40) -#define POLLSOCK (0x80) -#define POLLMASK (0xC0) +#define POLLMASK (0x40) Review comment: Sorry, I don't understand how the proposed approach is less consistent than the current one. In fact, I think it is kinda normal to define a mask based on the existing values the it should "mask". ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org