xiaoxiang781216 commented on a change in pull request #2736:
URL: https://github.com/apache/incubator-nuttx/pull/2736#discussion_r564190459
##########
File path: drivers/lwl_console.c
##########
@@ -208,11 +208,17 @@ static bool write24bits(uint8_t port, uint32_t val)
static bool read8bits(uint8_t port, uint8_t * store)
Review comment:
add FAR
##########
File path: drivers/lwl_console.c
##########
@@ -235,16 +242,17 @@ static int lwlconsole_ioctl(struct file *filep, int cmd,
unsigned long arg)
* Name: lwlconsole_read
****************************************************************************/
-static ssize_t lwlconsole_read(struct file *filep, char *buffer,
+static ssize_t lwlconsole_read(FAR struct file *filep, FAR char *buffer,
size_t buflen)
{
- if (buflen == 0 || !linkactive())
+ if (buflen == 0)
{
return 0;
}
- while (!read8bits(LWL_PORT_CONSOLE, (uint8_t *) buffer))
+ if (!read8bits(LWL_PORT_CONSOLE, (uint8_t *) buffer))
Review comment:
add FAR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
