xiaoxiang781216 commented on a change in pull request #566: URL: https://github.com/apache/incubator-nuttx-apps/pull/566#discussion_r563470913
########## File path: crypto/mbedtls/apps/selftest/Makefile ########## @@ -0,0 +1,33 @@ +############################################################################ +# apps/crypto/mbedtls/apps/selftest/Makefile +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# +############################################################################ + +include $(APPDIR)/Make.defs +include ../Makefile + +# mbedtls built-in benchmark application info + +PROGNAME = "mbedselftest" +PRIORITY = $(CONFIG_MBEDTLS_APP_SELFTEST_PRIORITY) +STACKSIZE = $(CONFIG_MBEDTLS_APP_SELFTEST_STACKSIZE) +MODULE = $(CONFIG_MBEDTLS_APP_SELFTEST) + +MAINSRC = $(MBEDPROGDIR)/test/selftest.c Review comment: > You cannot call `include $(APPDIR)/Application.mk` twice in the same make file which is they need to be in there own folders. But I don't think that is related to this path issue. but you can specify multiple apps in PROGNAME and MAINSRC like zmodem: https://github.com/apache/incubator-nuttx-apps/blob/master/system/zmodem/Makefile#L38 https://github.com/apache/incubator-nuttx-apps/blob/master/system/zmodem/Makefile#L45 > also careful with your paths. > `crypto/mbedtls/programs/test` does not exist. `crypto/mbedtls/mbedtls/programs/test` does, but that is inside the downloaded source. Yes, we can't put into the download folder, crypto/mbedtls/Makefile may a better location for apps too with the multiple apps trick. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
