[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2503: Re-organise ESP32 boards and introduce two more.

[GitBox]

xiaoxiang781216 commented on a change in pull request #2503:
URL: https://github.com/apache/incubator-nuttx/pull/2503#discussion_r540178668



##########
File path: boards/xtensa/esp32/common/src/esp32_wdt.c
##########
@@ -1,5 +1,5 @@
 /****************************************************************************
- * boards/xtensa/esp32/esp32-core/src/esp32_wtd.c
+ * boards/xtensa/esp32/common/src/esp32_wtd.c

Review comment:
       eps32_wtd.c to esp32_wdt.c

##########
File path: arch/xtensa/src/esp32/Make.defs
##########
@@ -162,10 +162,10 @@ ifeq ($(CONFIG_ESP32_PARTITION),y)
 CHIP_CSRCS += esp32_partition.c
 endif
 
-ifeq ($(CONFIG_WATCHDOG),y)
-CHIP_CSRCS += esp32_wtd_lowerhalf.c
 ifeq ($(CONFIG_ESP32_WDT),y)
 CHIP_CSRCS += esp32_wtd.c
+ifeq ($(CONFIG_WATCHDOG),y)
+CHIP_CSRCS += esp32_wtd_lowerhalf.c

Review comment:
       esp32_wtd_lowerhalf.c to esp32_wdt_lowerhalf.c

##########
File path: boards/xtensa/esp32/common/include/esp32_board_tim.h
##########
@@ -18,8 +18,8 @@
  *
  ****************************************************************************/
 
-#ifndef __BOARDS_XTENSA_ESP32_COMMON_INCLUDE_TIMER_H
-#define __BOARDS_XTENSA_ESP32_COMMON_INCLUDE_TIMER_H
+#ifndef __BOARDS_XTENSA_ESP32_COMMON_INCLUDE_BOARD_TIMER_H

Review comment:
       __BOARDS_XTENSA_ESP32_COMMON_INCLUDE_BOARD_TIMER_H to
   __BOARDS_XTENSA_ESP32_COMMON_INCLUDE_BOARD_TIM_H

##########
File path: arch/xtensa/src/esp32/Make.defs
##########
@@ -164,7 +164,7 @@ endif
 
 ifeq ($(CONFIG_WATCHDOG),y)
 CHIP_CSRCS += esp32_wtd_lowerhalf.c
-ifeq ($(CONFIG_ESP32_WTD),y)
+ifeq ($(CONFIG_ESP32_WDT),y)
 CHIP_CSRCS += esp32_wtd.c

Review comment:
       esp32_wtd.c to esp32_wdt.c

##########
File path: boards/xtensa/esp32/common/src/esp32_wdt.c
##########
@@ -23,33 +23,34 @@
  ****************************************************************************/
 
 #include <nuttx/config.h>
+
+#include <sys/types.h>
 #include <debug.h>
+
 #include "esp32_wtd_lowerhalf.h"

Review comment:
       should we change esp32_wtd_lowerhalf.h to esp32_wdt_lowerhalf.h




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org