btashton commented on a change in pull request #2415:
URL: https://github.com/apache/incubator-nuttx/pull/2415#discussion_r536580737
##########
File path: net/inet/ipv4_setsockopt.c
##########
@@ -184,16 +189,41 @@ int ipv4_setsockopt(FAR struct socket *psock, int option,
}
break;
- /* The following IPv4 socket options are defined, but not implemented */
-
- case IP_MULTICAST_IF: /* Set local device for a multicast
- * socket */
case IP_MULTICAST_TTL: /* Set/read the time-to-live value of
* outgoing multicast packets */
+ {
+ if (psock->s_type != SOCK_DGRAM ||
+ value_len != sizeof(int))
Review comment:
For Linux for most of these options both signed int and unsigned char
are supported and they just dereference and cast the value to in in the case of
unsigned char to a signed int.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
