davids5 commented on a change in pull request #2391:
URL: https://github.com/apache/incubator-nuttx/pull/2391#discussion_r531627469
##########
File path: boards/arm/stm32f7/stm32f746g-disco/include/board.h
##########
@@ -366,7 +374,7 @@
#define GPIO_TP_INT (GPIO_INPUT|GPIO_FLOAT|GPIO_EXTI|GPIO_PORTI|GPIO_PIN13)
-#define FT5x06_I2C_ADDRESS 0x38
+#define FT5x06_I2C_ADDRESS (0x70 >> 1)
Review comment:
Defining them shifted, (what you would see on the bus) then shifting
them back is confusing. I would avoid the confusion, and use 7-bit address in
the header file and put a comment that says `/* 7 bit address */`
After all what will `i2cdetect` show? 0x38, If I then grep 0x38. I will
not find this file!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
