xiaoxiang781216 commented on a change in pull request #2347:
URL: https://github.com/apache/incubator-nuttx/pull/2347#discussion_r530761629
##########
File path: fs/spiffs/src/spiffs_core.c
##########
@@ -1534,8 +1534,10 @@ void spiffs_fobj_event(FAR struct spiffs_s *fs,
FAR struct spiffs_file_s *next;
int16_t objid = objid_raw & ~SPIFFS_OBJID_NDXFLAG;
+#ifdef CONFIG_DEBUG_FS_INFO
Review comment:
why need add ifdef?
##########
File path: arch/x86_64/src/common/up_assert.c
##########
@@ -250,7 +250,7 @@ void up_assert(const char *filename, int lineno)
board_autoled_on(LED_ASSERTION);
-#if CONFIG_TASK_NAME_SIZE > 0
+#if CONFIG_TASK_NAME_SIZE > 0 && defined(CONFIG_DEBUG_ALERT)
Review comment:
why need check CONFIG_DEBUG_ALERT additionally?
##########
File path: drivers/lcd/st7567.c
##########
@@ -747,8 +749,10 @@ static int st7567_setpower(struct lcd_dev_s *dev, int
power)
struct st7567_dev_s *priv = (struct st7567_dev_s *)dev;
DEBUGASSERT(priv && (unsigned)power <= CONFIG_LCD_MAXPOWER);
- ginfo("power: %s powered: %s\n",
- st7567_powerstring(power), st7567_powerstring(priv->powered));
+
+ /* ginfo("power: %s powered: %s\n",
Review comment:
should we remove it directly?
##########
File path: drivers/lcd/st7567.c
##########
@@ -729,7 +729,9 @@ static int st7567_getpower(struct lcd_dev_s *dev)
{
struct st7567_dev_s *priv = (struct st7567_dev_s *)dev;
DEBUGASSERT(priv);
- ginfo("powered: %s\n", st7567_powerstring(priv->powered));
+
+ /* ginfo("powered: %s\n", st7567_powerstring(priv->powered)); */
Review comment:
should we remove it directly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
