xiaoxiang781216 commented on a change in pull request #2324: URL: https://github.com/apache/incubator-nuttx/pull/2324#discussion_r526923205
########## File path: libs/libc/audio/libsrc/Make.defs ########## @@ -0,0 +1,53 @@ +############################################################################ +# audio/libsrc/Make.defs +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# +############################################################################ + +ifeq ($(CONFIG_AUDIO_SRC),y) + +PACKAGE=libsamplerate +VERSION=0.1.9 + +libsamplerate: + $(Q) wget https://codeload.github.com/libsndfile/libsamplerate/zip/master -O libsamplerate.zip + $(Q) unzip -o libsamplerate.zip + $(Q) mv libsamplerate-master libsamplerate + $(Q) patch -Np1 -d libsamplerate <audio/libsrc/0002-add-audio-quality-options.patch + $(Q) cp -rf libsamplerate/src/samplerate.h $(TOPDIR)$(DELIM)include$(DELIM)nuttx$(DELIM)audio$(DELIM) + +depend:: libsamplerate + +CSRCS += samplerate.c +CSRCS += src_sinc.c +CSRCS += src_linear.c +CSRCS += src_zoh.c + +CFLAGS += -DPACKAGE=\"$(PACKAGE)\" -DVERSION=\"$(VERSION)\" + +VPATH += libsamplerate/src +SUBDIRS += libsamplerate/src +DEPPATH += --dep-path libsamplerate/src + +clean:: Review comment: change to distclean ########## File path: libs/libc/audio/libsrc/Make.defs ########## @@ -0,0 +1,53 @@ +############################################################################ +# audio/libsrc/Make.defs +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# +############################################################################ + +ifeq ($(CONFIG_AUDIO_SRC),y) + +PACKAGE=libsamplerate +VERSION=0.1.9 + +libsamplerate: + $(Q) wget https://codeload.github.com/libsndfile/libsamplerate/zip/master -O libsamplerate.zip + $(Q) unzip -o libsamplerate.zip + $(Q) mv libsamplerate-master libsamplerate + $(Q) patch -Np1 -d libsamplerate <audio/libsrc/0002-add-audio-quality-options.patch Review comment: change 0002 to 0001 ########## File path: libs/libc/audio/libsrc/0002-add-audio-quality-options.patch ########## @@ -0,0 +1,82 @@ +From 8d709a69b23efc52030824ae21db889589467d8c Mon Sep 17 00:00:00 2001 +From: Alin Jerpelea <alin.jerpe...@sony.com> +Date: Mon, 16 Nov 2020 09:44:17 +0100 +Subject: [PATCH] add audio quality options Review comment: should we upstream this path to mainline too? ########## File path: libs/libc/audio/libsrc/Make.defs ########## @@ -0,0 +1,53 @@ +############################################################################ +# audio/libsrc/Make.defs +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# +############################################################################ + +ifeq ($(CONFIG_AUDIO_SRC),y) + +PACKAGE=libsamplerate +VERSION=0.1.9 + +libsamplerate: + $(Q) wget https://codeload.github.com/libsndfile/libsamplerate/zip/master -O libsamplerate.zip + $(Q) unzip -o libsamplerate.zip + $(Q) mv libsamplerate-master libsamplerate + $(Q) patch -Np1 -d libsamplerate <audio/libsrc/0002-add-audio-quality-options.patch + $(Q) cp -rf libsamplerate/src/samplerate.h $(TOPDIR)$(DELIM)include$(DELIM)nuttx$(DELIM)audio$(DELIM) + +depend:: libsamplerate Review comment: change to context ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
