xiaoxiang781216 commented on a change in pull request #2222: URL: https://github.com/apache/incubator-nuttx/pull/2222#discussion_r524856580
########## File path: arch/sim/include/types.h ########## @@ -44,6 +44,8 @@ * Included Files ****************************************************************************/ +#include <nuttx/compiler_stdint.h> Review comment: So, I think that it's enough to correct typedef to ensure _xxx same as what compiler want. compiler_stdint.h is redundant and make the confusion(why define the same type twice) because the compiler can generate the mismatch warning even without including compiler_stdint.h ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org