yamt commented on a change in pull request #2111:
URL: https://github.com/apache/incubator-nuttx/pull/2111#discussion_r524284876
##########
File path: boards/sim/sim/sim/scripts/Make.defs
##########
@@ -100,6 +100,24 @@ CXXFLAGS := $(ARCHWARNINGSXX) $(ARCHOPTIMIZATION) \
CPPFLAGS := $(ARCHINCLUDES) $(ARCHDEFINES) $(EXTRAFLAGS)
AFLAGS := $(CFLAGS) -D__ASSEMBLY__
+ifeq ($(CONFIG_LIBCXX),y)
+ CXXFLAGS += -std=c++14 -D_LIBCPP_STD_VER=14
+
+ ifeq ($(CONFIG_HOST_MACOS),y)
+ # macOS uses libc++abi
+ CXXFLAGS += -DLIBCXX_BUILDING_LIBCXXABI
Review comment:
is it?
i thought it was rather os specific.
macOS uses libc++abi, other BSDs use libcxxrt, ubuntu uses libsupc++, etc.
anyway, Make.defs is the appropriate place to put toolchain-specific bits,
isn't it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
