fjpanag commented on pull request #2177: URL: https://github.com/apache/incubator-nuttx/pull/2177#issuecomment-727200284
> > @v01d thank you for the details on the matter. It was constructive nevertheless. > > Do you both agree that this change is correct? Shall I proceed with the nxstyle fixes? > > _(As a side note, I have still trouble understanding some of the nxstyle errors. Is there any guide, or any documentation on code style conventions?)_ > > Yes it is a good solution. I may tend to not muddy the code with the ifdef tree. > > Pulling the compile time change to the preprocessor section,. > > ``` > #if (STM32_SYSCLK_FREQUENCY <= 24000000) > #define FLASH_ACR_LATENCY FLASH_ACR_LATENCY_0 > #elif (STM32_SYSCLK_FREQUENCY <= 48000000) > #define FLASH_ACR_LATENCY FLASH_ACR_LATENCY_1 > #else > #define FLASH_ACR_LATENCY FLASH_ACR_LATENCY_1 > #endif > ``` > > Then the code is > > ``` > regval |= (FLASH_ACR_LATENCY | FLASH_ACR_PRTFBE); > ``` This is a good idea, but right now it is not easy for me to do this change (for practical/personal reasons). If you don't mind, you may merge it as is, and I will change it in a different PR, where chip Vin will also be handled. If you insist, I can correct this sometime next week, and the other PR will only be for Vin. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
