acassis commented on pull request #2230: URL: https://github.com/apache/incubator-nuttx/pull/2230#issuecomment-726063580
> > @fckruegel hmm, there is a conflict in the include/nuttx/analog/ioctl.h did you see that? I think it was modified since you submit the original PR. > > Yes, I know. This affects the IOCTL code allocations. The STM32G4 codes came in in the meantime. Just put my block of numbers after these. > > Maybe we should add another system call analog_get_ioctl_range(), which would allow the OS to allocate the ranges dynamically. Linux switches to this model from a staic allocation of device major numbers after they ran out of number space. Yes, it could be a good idea. But I suggest you just fix the ioctl using the static approach and then propose to make the ioctl definition more dynamic. What do you think? Makes sense? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
