raiden00pl commented on a change in pull request #2270:
URL: https://github.com/apache/incubator-nuttx/pull/2270#discussion_r520334006
##########
File path: arch/arm/src/nrf52/hardware/nrf52_spi.h
##########
@@ -153,13 +154,13 @@
#define SPIM_ENABLE_DIS (0) /* Disable SPIM */
#define SPIM_ENABLE_EN (0x7 << 0) /* Enable SPIM */
-/* PSEL(MOSI/MISO/SCK/CSN) Register */
+/* PSEL* Registers */
-#define SPIM_PSEL_PIN_SHIFT (0) /* Bits 0-4: pin number */
-#define SPIM_PSEL_PIN_MASK (0x1f << SPIM_PSEL_PIN_SHIFT)
-#define SPIM_PSEL_PORT_SHIFT (5) /* Bit 5: port number */
-#define SPIM_PSEL_PORT_MASK (0x1 << SPIM_PSEL_PORT_SHIFT)
-#define SPIM_PSEL_CONNECTED (1 << 31) /* Bit 31: Connection */
+#define SPIM_PSEL_PIN_SHIFT (0) /* Bits 0-4: SCK pin number */
+#define SPIM_PSEL_PIN_MASK (0x1f << SPIM_PSELSCK_PIN_SHIFT)
+#define SPIM_PSEL_PORT_SHIFT (5) /* Bit 5: SCK port number */
+#define SPIM_PSEL_PORT_MASK (0x1 << SPIM_PSELSCK_PORT_SHIFT)
+#define SPIM_PSEL_DISCONNECTED (1 << 31) /* Bit 31: Disconnect */
Review comment:
This bit is called CONNECT in the manual, not DISCONNECT. Shouldn't we
stick to the manufacture's name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
