btashton commented on a change in pull request #2115: URL: https://github.com/apache/incubator-nuttx/pull/2115#discussion_r513522024
########## File path: tools/Makefile.win ########## @@ -392,17 +392,22 @@ ifeq ($(CONFIG_BUILD_2PASS),y) $(Q) $(MAKE) -C $(CONFIG_PASS1_BUILDIR) LINKLIBS="$(LINKLIBS)" USERLIBS="$(USERLIBS)" "$(CONFIG_PASS1_TARGET)" endif $(Q) $(MAKE) -C $(ARCH_SRC) EXTRA_OBJS="$(EXTRA_OBJS)" LINKLIBS="$(LINKLIBS)" EXTRAFLAGS="$(KDEFINE) $(EXTRAFLAGS)" $(BIN) + echo $(BIN) > $(NUTTXNAME).manifest + printf '%s\n' *.map >> $(NUTTXNAME).manifest Review comment: echo will put them all on the same line so it would look like this: ``` nuttx nuttx.hex System.map User.map ``` I think printf is the best option ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org