masayuki2009 commented on pull request #425: URL: https://github.com/apache/incubator-nuttx-apps/pull/425#issuecomment-717783143
> > nshlib/nsh_altconsole.c calls non-existent flush(), typo for fflush(). > > Other than this, change works for me. Tested with proprietary board. I'm using slightly older apps and backported the change though. > > My fault, @masayuki2009 could you test my new change? I am wondering why the PR pass the build without error or warning. @xiaoxiang781216 At least, stm32f4discovery:usbnsh does not use nsh_altconsole.c. Anyway, could you fix the file and rebase the fclose branch to the latest master and push the commit again? Also, I think we need to apply https://github.com/apache/incubator-nuttx/pull/1997 as well. If so, please rebase the xiaoxiang781216:fclose3 to the latest master. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
