AlexanderVasiljev commented on a change in pull request #2036:
URL: https://github.com/apache/incubator-nuttx/pull/2036#discussion_r508274803
##########
File path: drivers/serial/serial.c
##########
@@ -854,6 +854,16 @@ static ssize_t uart_read(FAR struct file *filep, FAR char
*buffer, size_t buflen
break;
}
+ else if (filep->f_inode == 0)
Review comment:
The close function has already a logic to wait for clearing transmit
buffer. So the close function will block.
/* Prevent blocking if the device is opened with O_NONBLOCK /
if ((filep->f_oflags & O_NONBLOCK) == 0)
{
/ Now we wait for the transmit buffer(s) to clear */
uart_tcdrain(dev, 4 * TICK_PER_SEC);
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
