patacongo edited a comment on pull request #2016:
URL: https://github.com/apache/incubator-nuttx/pull/2016#issuecomment-711091610
> This is a trivial change that is all of 3 API calls, how else could this
be implemented? Are we somehow now prevented for ever adding DAC support for
STM32 in boards?
There are many other sources to leverage STM32 DAC files. Unfortunately,
one that has license issues was selected. Haltian tends to slap their
copyright on everything.
So, yes, we can support STM32 DAC. No we cannot let this code into the
repository. We have to play by the rules.
Hmm... It looks like all of the STM32 DAC drivers have license issues:
$ find boards/ -name "stm32*_dac.c" | xargs grep Copyright
boards/arm/stm32/olimex-stm32-e407/src/stm32_dac.c: * Copyright (C)
2019 Acutronics Robotics All rights reserved.
boards/arm/stm32l4/nucleo-l432kc/src/stm32_dac.c: * Copyright (C) 2017
Haltian Ltd. All rights reserved.
boards/arm/stm32l4/nucleo-l452re/src/stm32_dac.c: * Copyright (C) 2017
Haltian Ltd. All rights reserved.
boards/arm/stm32l4/nucleo-l496zg/src/stm32_dac.c: * Copyright (C) 2017
Haltian Ltd. All rights reserved.
boards/arm/stm32l4/stm32l4r9ai-disco/src/stm32_dac.c: * Copyright (C)
2017-2018 Haltian Ltd. All rights reserved.
The options then are only get a CCLA from Haltian, or to identify this as
third party code in the LICENSE file. Isn't that right? In any event, it
should be removed for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
