patacongo commented on a change in pull request #2009:
URL: https://github.com/apache/incubator-nuttx/pull/2009#discussion_r506991730
##########
File path: boards/arm/stm32l4/nucleo-l432kc/src/stm32_dac.c
##########
@@ -0,0 +1,97 @@
+/*****************************************************************************
+ * boards/arm/stm32l4/nucleo-l432kc/src/stm32_dac.c
+ *
+ * Copyright (C) 2017 Haltian Ltd. All rights reserved.
Review comment:
I think that this change must be reverted. We cannot being ANY new
files into the repositories that do not have Apache 2.0 license.
UNLESS we follow the rules for third party software. If it is not Apache
2.0, it is third party and not truly a part of NuttX.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
