xiaoxiang781216 commented on a change in pull request #421:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/421#discussion_r501524860
##########
File path: nshlib/nsh_command.c
##########
@@ -518,6 +518,18 @@ static const struct cmdmap_s g_cmdmap[] =
{ "time", cmd_time, 2, 2, "\"<command>\"" },
#endif
+#ifdef CONFIG_DRIVER_NOTECTL
+# ifndef CONFIG_NSH_DISABLE_TRACE
+ { "trace", cmd_trace, 1, CONFIG_NSH_MAXARGUMENTS,
Review comment:
Sure, but your tool is a superset of sched_note, should we merge both
into one to reduce the maintainence cost? BTW, sched_node may already in broken
state with the recent note change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
