patacongo commented on a change in pull request #1912:
URL: https://github.com/apache/incubator-nuttx/pull/1912#discussion_r497528189
##########
File path: arch/arm/src/common/arm_interruptcontext.c
##########
@@ -59,5 +59,15 @@
bool up_interrupt_context(void)
{
- return CURRENT_REGS != NULL;
+#ifdef CONFIG_SMP
+ irqstate_t flags = up_irq_save();
Review comment:
>
>
> @patacongo
>
> This is the same as what I did for this_task() in sched/sched_thistask.c
> So, may I merge this PR?
Well, we should never merge our own PRs. But I suppose we should merge this
now. There is, however, a problem with the ARMv7-A with the GIC. The use of
up_irq_save() will not disable the SGIs used for inter-processor signalling, at
least not until use of the ICCMPR is used as you suggested.
Perhaps we should add a comment about this in the PR? What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
