v01d commented on pull request #1893: URL: https://github.com/apache/incubator-nuttx/pull/1893#issuecomment-698336847
Very exciting PR! Sadly I don't have an ESP32 to try it out. Hopefully someone else can. Adding the `-` to all includes for Make.defs on arch Makefiles isn't something we got away from recently? I understand this may be necessary since the Makefile will be called before the board Make.defs is in place, right? I'm guessing we should also note the License of the resulting binary if the closed blob is included in the build. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
