v01d commented on a change in pull request #1843:
URL: https://github.com/apache/incubator-nuttx/pull/1843#discussion_r491473802
##########
File path: tools/Config.mk
##########
@@ -458,7 +458,8 @@ define CLEAN
endef
else
define CLEAN
- $(Q) rm -f *$(OBJEXT) *$(LIBEXT) *~ .*.swp
+ $(call DELFILE, $(wildcard $(foreach obj, $(OBJS), $(addsuffix /$(obj),
$(subst :, ,$(VPATH))))))
+ $(call DELFILE, *$(OBJEXT) *$(LIBEXT) *~ .*.swp)
Review comment:
So, I'm confused on what do you think is best. I agree that not having
*$(OBJEXT) is better and safer, and for me it works just using $(OBJS) (but
potentially leaves extra .o's there). However, you then mentioned to add it in
a second step, so I'm not following your idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
