xiaoxiang781216 commented on a change in pull request #380:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/380#discussion_r487401602
##########
File path: Makefile
##########
@@ -100,9 +104,9 @@ $(SYMTABOBJ): %$(OBJEXT): %.c
$(BIN): $(SYMTABOBJ)
ifeq ($(CONFIG_CYGWIN_WINTOOL),y)
- $(call ARLOCK, "${shell cygpath -w $(BIN)}", $^)
+ $(call ARCHIVE, "${shell cygpath -w $(BIN)}", $^)
Review comment:
Should we use ARCHIVE_ADD here?
##########
File path: Makefile
##########
@@ -100,9 +104,9 @@ $(SYMTABOBJ): %$(OBJEXT): %.c
$(BIN): $(SYMTABOBJ)
ifeq ($(CONFIG_CYGWIN_WINTOOL),y)
- $(call ARLOCK, "${shell cygpath -w $(BIN)}", $^)
+ $(call ARCHIVE, "${shell cygpath -w $(BIN)}", $^)
Review comment:
Should we use ARCHIVE_ADD here?
##########
File path: Makefile
##########
@@ -100,9 +104,9 @@ $(SYMTABOBJ): %$(OBJEXT): %.c
$(BIN): $(SYMTABOBJ)
ifeq ($(CONFIG_CYGWIN_WINTOOL),y)
- $(call ARLOCK, "${shell cygpath -w $(BIN)}", $^)
+ $(call ARCHIVE, "${shell cygpath -w $(BIN)}", $^)
Review comment:
Should we use ARCHIVE_ADD here?
##########
File path: Makefile
##########
@@ -100,9 +104,9 @@ $(SYMTABOBJ): %$(OBJEXT): %.c
$(BIN): $(SYMTABOBJ)
ifeq ($(CONFIG_CYGWIN_WINTOOL),y)
- $(call ARLOCK, "${shell cygpath -w $(BIN)}", $^)
+ $(call ARCHIVE, "${shell cygpath -w $(BIN)}", $^)
Review comment:
Should we use ARCHIVE_ADD here?
##########
File path: Makefile
##########
@@ -100,9 +104,9 @@ $(SYMTABOBJ): %$(OBJEXT): %.c
$(BIN): $(SYMTABOBJ)
ifeq ($(CONFIG_CYGWIN_WINTOOL),y)
- $(call ARLOCK, "${shell cygpath -w $(BIN)}", $^)
+ $(call ARCHIVE, "${shell cygpath -w $(BIN)}", $^)
Review comment:
Should we use ARCHIVE_ADD here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
