ppisa commented on PR #19047: URL: https://github.com/apache/nuttx/pull/19047#issuecomment-4640390751
For the patch, I would suggest to only skip call of `fb->vtable->updatearea` if it is set to NULL, not to go to panic. Because `CONFIG_FB_UPDATE` can be set to support combination of displays where one needs it and other has mapped real device side frame-buffer which is scanned to the screen periodically by hardware. `FBIO_UPDATE` does solve such situation by return of `-ENOTTY` but it can be simply ignored and common code can be used for displays with and without need of explicit updates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
