acassis commented on code in PR #19049: URL: https://github.com/apache/nuttx/pull/19049#discussion_r3367987741
########## fs/vfs/fs_pseudofile.c: ########## @@ -493,6 +493,19 @@ int pseudofile_create(FAR struct inode **node, FAR const char *path, (*node)->i_flags = 1; (*node)->u.i_ops = &g_pseudofile_ops; (*node)->i_private = pf; + +#if defined(CONFIG_PSEUDOFS_ATTRIBUTES) && \ + defined(CONFIG_SCHED_USER_IDENTITY) + FAR struct tcb_s *rtcb; Review Comment: New variables cannot be created in the middle of the function, it is incompatible with C89 that NuttX requires in common code, otherwise it cannot be used with retro computing that only supports C89 compilers. Please move the variable definition to the top of the function -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
