Zepp-Hanzj commented on PR #3527: URL: https://github.com/apache/nuttx-apps/pull/3527#issuecomment-4633394853
> When I try to compile your configuration I get this error: > > ``` > CP: /home/linguini/coding/nuttx-space/nuttx/include/nuttx/config.h > CC: grp/lib_getgrbuf.c generator.c: In function ‘replay_worker’: > generator.c:205:44: error: ‘const struct orb_metadata’ has no member named ‘o_format’ > 205 | sensor_gen->obj.meta->o_format, data); > | ^~ > generator.c: In function ‘fake_worker’: > generator.c:287:38: error: ‘const struct orb_metadata’ has no member named ‘o_format’ > 287 | sensor_gen->obj.meta->o_format, data) < 0) > | ^~ > make[2]: *** [/home/linguini/coding/nuttx-space/apps/Application.mk:330: generator.c.home.linguini.coding.nuttx-space.apps.system.uorb.o] Error 1 > make[2]: *** Waiting for unfinished jobs.... > IN: mm/libmm.a -> staging/libmm.a make[1]: *** [Makefile:54: /home/linguini/coding/nuttx-space/apps/system/uorb_all] Error 2 > make[1]: *** Waiting for unfinished jobs.... > CC: pthread/pthread_mutexattr_setpshared.c make: *** [tools/LibTargets.mk:248: /home/linguini/coding/nuttx-space/apps/libapps.a] Error 2 > make: *** Waiting for unfinished jobs.... > ``` Sorry for the oversight. The compilation error occurs because generator.c uses o_format to parse sensor data from stdin, but CONFIG_UORB_FORMAT wasn't being selected when only UORB_GENERATOR was enabled. Fixed by adding select UORB_FORMAT to UORB_GENERATOR in Kconfig. Verified locally: Only UORB enabled → UORB_FORMAT not selected (no overhead) UORB_GENERATOR enabled → UORB_FORMAT auto-selected, build passes Thanks for catching this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
