acassis commented on PR #18493: URL: https://github.com/apache/nuttx/pull/18493#issuecomment-4013072703
> Thanks @arjav1528 :-) > > * There are three functional changes in this PR, please provide each change as separate commit with proper description. > > * Build and runtime tests are mandatory, if @acassis can provide them as your guide this is okay too :-) > > * Why removing `CONFIG_ARCH_IRQBUTTONS` from `buttons` configs? I see no explanation in the git commit message. @arjav1528 @cederom yes, boards modifications, documentation and driver Kconfig should be in separated commits. I think he tried to remove CONFIG_ARCH_IRQBUTTONS to fix the issue in the ESP32, please don't modify it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
