linguini1 commented on code in PR #18396: URL: https://github.com/apache/nuttx/pull/18396#discussion_r2886183610
########## tools/test_mkpasswd.c: ########## Review Comment: It's okay to check your initial PoC logic, but shouldn't be included into the repo unless it can actually perform a useful test later. I think it's best to invoke the actual binary, since that's the goal of the test. If you duplicate, you're only testing your duplicated logic, which is not very helpful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
